[pulsar-broker] Handle lookup redirect for V1-topics with different cluster #12743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
requested review from
merlimat,
sijie,
jerrypeng,
jiazhai,
eolivelli and
codelipenghui
|
@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs? |
eolivelli
approved these changes
Nov 11, 2021
| } | ||
| return pulsarResources.getClusterResources().listAsync() | ||
| .thenApply(clusters -> { | ||
| log.info("clusters {}, cluster {}",clusters, topicName.getCluster()); |
There was a problem hiding this comment.
Will this be printed out maty times?
There was a problem hiding this comment.
oh.. that was for testing. let me remove it.
rdhabalia
force-pushed
the
lookup_cluster
branch
from
cb6cb7b
to
4d36d02
Compare
|
@rdhabalia seems this is a bug fix and do not affect docs? |
codelipenghui
approved these changes
Nov 11, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, if pulsar broker is not redirecting lookup requests if V1-topic belongs to the different region instead it gives Authorization Exception.
Modification
Broker should be able to redirect lookup to appropriate cluster so, user doesn't have to change broker URL and able to connect to right region after following redirect.