Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump function's go client version to v0.7.0 #12839

Merged

Conversation

nlu90
Copy link
Member

@nlu90 nlu90 commented Nov 16, 2021

Motivation

New go client v0.7.0 released recently. We need to bump the function's go client version.

Modifications

version change.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 16, 2021
@nlu90 nlu90 changed the title bump function's go client version to v0.7.0 [WIP] bump function's go client version to v0.7.0 Nov 17, 2021
@nlu90 nlu90 changed the title [WIP] bump function's go client version to v0.7.0 bump function's go client version to v0.7.0 Nov 17, 2021
@cckellogg
Copy link
Contributor

I think the mock message needs updated since there was a new method GetEncryptionContext() added in 0.7.0 for encryption.

https://github.com/apache/pulsar-client-go/blob/master/pulsar/message.go#L123
https://github.com/apache/pulsar/blob/master/pulsar-function-go/pf/mockMessage_test.go#L29

@nlu90
Copy link
Member Author

nlu90 commented Nov 17, 2021

/pulsarbot run-failure-checks

1 similar comment
@nlu90
Copy link
Member Author

nlu90 commented Nov 18, 2021

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit f78fdac into apache:master Nov 19, 2021
@codelipenghui codelipenghui deleted the neng/update-function-go-client branch November 19, 2021 14:59
dlg99 pushed a commit to dlg99/pulsar that referenced this pull request Nov 23, 2021
### Motivation

New go client v0.7.0 released recently. We need to bump the function's go client version.
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
### Motivation

New go client v0.7.0 released recently. We need to bump the function's go client version.
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
### Motivation

New go client v0.7.0 released recently. We need to bump the function's go client version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants