Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch exceptions in scheduled tasks to prevent unintended cancellation #12853

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Catch exceptions in scheduled tasks to prevent unintended cancellation #12853

merged 3 commits into from
Nov 19, 2021

Commits on Nov 17, 2021

  1. Catch exceptions in scheduled tasks to prevent unintended cancellation 

    - ScheduledExecutorService#scheduleAtFixedRate won't schedule the next execution if running the task
  throws an exception. This can lead to unintended cancellation of the scheduled task in failure scenarios.
    @lhotari
    lhotari committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    5440b29 View commit details
    Browse the repository at this point in the history

  2. Address review feedback: use private constructor

    @lhotari
    lhotari committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    bff9651 View commit details
    Browse the repository at this point in the history

  3. Address review feedback: Use private inner class instead of Lambda

    @lhotari
    lhotari committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    520f4a1 View commit details
    Browse the repository at this point in the history