Handle exception double #12881
Merged
Handle exception double #12881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liangyepianzhou:Thanks for your contribution. For this PR, do we need to update docs? |
|
@liangyepianzhou:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
Jason918
reviewed
Nov 19, 2021
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryCacheImpl.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 19, 2021
codelipenghui
added
component/transactions
area/transaction
and removed
component/transactions
labels
merlimat
approved these changes
Nov 19, 2021
|
Good work @liangyepianzhou ! |
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 23, 2021
Fixes apache#12744 ### Motivation The exception here was handled twice, resulting in a null pointer exception. And the position will be updated twice. ### Modifications Keep the exceptionally() part and convert the whenComplete() into thenAccept().
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
Fixes apache#12744 ### Motivation The exception here was handled twice, resulting in a null pointer exception. And the position will be updated twice. ### Modifications Keep the exceptionally() part and convert the whenComplete() into thenAccept().
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Fixes apache#12744 ### Motivation The exception here was handled twice, resulting in a null pointer exception. And the position will be updated twice. ### Modifications Keep the exceptionally() part and convert the whenComplete() into thenAccept().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12744
Motivation
The exception here was handled twice, resulting in a null pointer exception.
And the position will be updated twice.
Modifications
Keep the exceptionally() part and convert the whenComplete() into thenAccept().
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc