-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 12883] Fix flaky caused by message receive timeout in testBlockBrokerDispatching #12954
Merged
eolivelli
merged 1 commit into
apache:master
from
Jason918:issue-12883-fix-flaky-in-step2+3
Nov 24, 2021
Merged
[Issue 12883] Fix flaky caused by message receive timeout in testBlockBrokerDispatching #12954
eolivelli
merged 1 commit into
apache:master
from
Jason918:issue-12883-fix-flaky-in-step2+3
Nov 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lhotari PTAL |
lhotari
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for looking into the @Jason918 . I wonder if there's some regression in performance that makes this test fail more often than before. WDYT? |
eolivelli
approved these changes
Nov 24, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jan 29, 2022
(cherry picked from commit 94736a4)
michaeljmarshall
pushed a commit
that referenced
this pull request
Feb 11, 2022
(cherry picked from commit 94736a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/test
cherry-picked/branch-2.8
Archived: 2.8 is end of life
cherry-picked/branch-2.9
Archived: 2.9 is end of life
doc-not-needed
Your PR changes do not impact docs
release/2.8.3
release/2.9.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12883
Motivation
As mentioned in #12883 (comment).
In PersistentStreamingDispatcherBlockConsumerTest.testBlockBrokerDispatching, there are still some flaky case other than timeout issue which fixed in #12943
Modifications
receive(timeout)
toreceive()
. If it does timeout, then test should fail.receive(timeout)
toreceive()
won't work. So increase timeout for now.Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc
Fix flaky.