Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functions] Override inactive_topic_policies in Pulsar Functions namespace creation #13048

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Nov 30, 2021

Motivation

Override inactive_topic_policies in Pulsar Functions namespace creation so that inactive topic deletion is always disabled for the Pulsar Functions namespace. This is to prevent potential problems which could be caused when broker.conf has been configured with BrokerDeleteInactiveTopicsEnabled=true.

Modifications

  • override inactive_topic_policies in Pulsar Functions namespace creation so that it is disabled.
  • fix checkstyle issues in the modified source code file PulsarWorkerService.java

…space creation

- so that inactive topic deletion is always disabled for the Pulsar Functions namespace
@lhotari lhotari added the doc-not-needed Your PR changes do not impact docs label Nov 30, 2021
@lhotari lhotari added this to the 2.10.0 milestone Nov 30, 2021
@lhotari lhotari self-assigned this Nov 30, 2021
@codelipenghui codelipenghui merged commit f561971 into apache:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants