[pulsar-broker] Make load-balancer config dynamic for the runtime tuning #13074
Conversation
rdhabalia
requested review from
merlimat,
sijie,
jiazhai,
eolivelli,
codelipenghui and
massakam
|
@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs? |
| @@ -1722,6 +1723,7 @@ | |||
|
|
|||
| @FieldContext( | |||
| category = CATEGORY_LOAD_BALANCER, | |||
| dynamic = true, | |||
| doc = "load balance load shedding strategy" | |||
| ) | |||
| private String loadBalancerLoadSheddingStrategy = "org.apache.pulsar.broker.loadbalance.impl.OverloadShedder"; | |||
There was a problem hiding this comment.
It seems this loadBalancerLoadSheddingStrategy is used on broker start, dynamic won't take effect.
Please check if all these configs are only used on broker start up.
There was a problem hiding this comment.
we would like to change config without deploying new code and dynamic config helps in that case. for a safe deployment we would like keep existing config, change config dynamically and do process restart without redeploying new code. so, this is an intentional code change.
There was a problem hiding this comment.
I get your point. But is a little confusing, if we just mark it dynamic, but we need to restart to make it take effect.
Most importantly, we need to tell the difference that which of these dynamic configs need broker restart, and which ones don't.
There was a problem hiding this comment.
yes, we can add into doc. I will add it.
There was a problem hiding this comment.
Only loadBalancerLoadSheddingStrategy needs restart? Have you checked others?
|
@rdhabalia can you please give me some pointers about how "dynamic" works ? |
|
@eolivelli dynamic config provides a way to change broker-config value dynamically using admin-api and it also persists those changed values and applies them on broker server startup. this feature is useful when you want to tune broker at runtime or experiment any value without deploying new release of changes. |
|
ping. |
I think it's a common require and we can add this as default feature for most of the configs. |
|
I think we kept most of them dynamic which are required. |
|
ping. can someone please review the PR? |
…ing (apache#13074) * [pulsar-broker] Make load-balancer config dynamic for the runtime tuning * add doc for dynamic restart
|
@momo-jun is doc updated for this PR? Can you help check? Thanks |
Anonymitaet
added
doc-complete
Motivation
There are a few load balancer config that requires tuning at runtime without restarting the broker. so, mark those configs dynamic so, admin can tune them based on cluster requirements.