Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current resourceUsage value as historyUsage when leader change in ThresholdShedder #13136

Merged

Conversation

hangc0276
Copy link
Contributor

Motivation

Fix #13119

Modification

  1. User current resourceUsage value as historyUsage value when leader change in ThresholdShedder to speed up getting the actual historyUsage value.

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, if I remember correctly, there aren't any tests for this class. It'd be good to add some to ensure the class behaves as designed.

@codelipenghui codelipenghui merged commit 6d9d24d into apache:master Dec 11, 2021
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
… ThresholdShedder (apache#13136)

### Motivation 
Fix apache#13119 

### Modification
1. User current resourceUsage value as historyUsage value when leader change in ThresholdShedder to speed up getting the actual historyUsage value.
codelipenghui pushed a commit that referenced this pull request Dec 21, 2021
… ThresholdShedder (#13136)

### Motivation
Fix #13119

### Modification
1. User current resourceUsage value as historyUsage value when leader change in ThresholdShedder to speed up getting the actual historyUsage value.

(cherry picked from commit 6d9d24d)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 21, 2021
zymap pushed a commit that referenced this pull request Dec 23, 2021
… ThresholdShedder (#13136)

### Motivation
Fix #13119

### Modification
1. User current resourceUsage value as historyUsage value when leader change in ThresholdShedder to speed up getting the actual historyUsage value.

(cherry picked from commit 6d9d24d)
@zymap zymap added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.3 release/2.9.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load balance shedding not in time with the strategy of ThresholdShedder
6 participants