Fix when deleting topic with NotFoundException, do not return to client. #13203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Outdated
Show resolved
Hide resolved
Technoboy-
force-pushed
the
add-not-found-exception
branch
from
43cdf84
to
d75c600
Compare
Ok, add related test. |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Dec 10, 2021
codelipenghui
requested review from
315157973,
congbobo184,
gaoran10,
hangc0276,
MarvinCai and
merlimat
merlimat
approved these changes
Dec 11, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12554.
Motivation
When deleting the topic, the user may exec cmd on broker-a, and everything goes well (means : asyncGetManagedLedgerInfo completes successfully) and decide to run
store.removeManagedLedger, but zk data is deleted by broker-b at this time, then it will throw NotFoundException (wrap KeeperException$NoNodeException) to client.I think this exception should treat as the delete topic action perform right.
Documentation
no-need-doc