-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump log4j to 2.15.0 #13226
Bump log4j to 2.15.0 #13226
Conversation
Should we add this PR to 2.8.2 since there is a security vulnerability for log4j < 2.15? @315157973 |
If there’s a security issue, we should also backport to 2.7 |
@BewareMyPower which vulnerability is it? severity level? |
Very serious |
@315157973 I don't see any vulnerability listed here: https://ossindex.sonatype.org/component/pkg:maven/org.apache.logging.log4j/log4j |
@315157973 I'll cherry pick to branch-2.8 and branch-2.7 . Since the issue is extremely severe, I think we need to expedite 2.8.2 and 2.7.4 releases. /cc @michaeljmarshall |
CVE-2021-44228 |
(cherry picked from commit 0015dab)
(cherry picked from commit 0015dab)
(cherry picked from commit 0015dab)
(cherry picked from commit 0015dab)
I also cherry-picked to branch-2.6 . I think it would make sense to do a 2.6.5 release since CVE-2021-44228 is such a severe issue. @merlimat @eolivelli @massakam WDYT? |
The workaround seems to be to set |
I can confirm that JVM system property |
CVE-2021-44228 is triggered if user provided input is passed to Logger's debug/info/warn/error method directly. It doesn't get triggered if user provided input is logged using {} placeholders. This reduces the likelyhood of the exploit quite a lot . |
workaround in Pulsar Helm Chart by setting |
It seems that using {} placeholders isn't sufficient: https://twitter.com/CZ_JanecekPetr/status/1469220756580179972 . The only confirmed workaround is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work.
This reverts commit 6bda122.
(cherry picked from commit 0015dab)
Modifications
Bump log4j to 2.15.0
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc
Only need to modify the license part