Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] add explanations for broker entry metadata #13336

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

Anonymitaet
Copy link
Member

@Anonymitaet Anonymitaet commented Dec 15, 2021

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Dec 15, 2021
@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Dec 15, 2021
@Anonymitaet
Copy link
Member Author

@BewareMyPower @codelipenghui @Huanli-Meng can you help review? Thanks

Copy link
Member

@shoothzj shoothzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, leave two comments

site2/docs/developing-binary-protocol.md Outdated Show resolved Hide resolved
site2/docs/developing-binary-protocol.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and only leave one minor comment.

site2/docs/developing-binary-protocol.md Show resolved Hide resolved
@Anonymitaet Anonymitaet merged commit 1f80634 into apache:master Dec 20, 2021
@Anonymitaet Anonymitaet deleted the 1215 branch December 20, 2021 11:35
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Dec 29, 2021
* [Doc] add explanations for broker entry metadata

* update

* update
dlg99 pushed a commit to dlg99/pulsar that referenced this pull request Jun 15, 2022
* [Doc] add explanations for broker entry metadata

* update

* update

(cherry picked from commit 1f80634)
eolivelli pushed a commit to datastax/pulsar that referenced this pull request Jun 16, 2022
* [Doc] add explanations for broker entry metadata

* update

* update

(cherry picked from commit 1f80634)
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed the typo. The config should be exposingBrokerEntryMetadataToClientEnabled , not enableExposingBrokerEntryMetadataToClient. Could you fix it?

See

private boolean exposingBrokerEntryMetadataToClientEnabled = false;

@Huanli-Meng
Copy link
Contributor

@Anonymitaet could you please help follow up with @BewareMyPower 's comments? Thanks.

@Anonymitaet
Copy link
Member Author

@BewareMyPower sorry I missed your comment

@Huanli-Meng thanks for your reminder!

I've updated it in #17099, PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants