-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] add explanations for broker entry metadata #13336
Conversation
@BewareMyPower @codelipenghui @Huanli-Meng can you help review? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, leave two comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and only leave one minor comment.
* [Doc] add explanations for broker entry metadata * update * update
* [Doc] add explanations for broker entry metadata * update * update (cherry picked from commit 1f80634)
* [Doc] add explanations for broker entry metadata * update * update (cherry picked from commit 1f80634)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed the typo. The config should be exposingBrokerEntryMetadataToClientEnabled
, not enableExposingBrokerEntryMetadataToClient
. Could you fix it?
See
pulsar/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Line 1357 in 4b757cf
private boolean exposingBrokerEntryMetadataToClientEnabled = false; |
@Anonymitaet could you please help follow up with @BewareMyPower 's comments? Thanks. |
@BewareMyPower sorry I missed your comment @Huanli-Meng thanks for your reminder! I've updated it in #17099, PTAL |
Add docs for #11553 and https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1639493174300500
Preview looks good: