Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Add clang-format check for Pulsar Wireshark dissector #13349

Conversation

Demogorgon314
Copy link
Member

Motivation

Currently, the Pulsar Wireshark dissector code doesn't format with clang style, we should add clang-format to format it.

Modifications

Add clang-format to format pulsarDissector.cc

Documentation

Need to update docs?

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 16, 2021
@BewareMyPower BewareMyPower added component/c++ type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use labels Dec 16, 2021
@BewareMyPower BewareMyPower added this to the 2.10.0 milestone Dec 16, 2021
@BewareMyPower BewareMyPower merged commit 73baf2d into apache:master Dec 16, 2021
@Demogorgon314 Demogorgon314 deleted the add-check-format-for-wireshark-dissector branch December 16, 2021 12:17
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
### Motivation

Currently, the Pulsar Wireshark dissector code doesn't format with clang style, we should add clang-format to format it.

### Modifications

Add clang-format to format `pulsarDissector.cc`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants