Optimize the debug log that affects performance, and unify the style #13498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liudezhi2098:Thanks for your contribution. For this PR, do we need to update docs? |
Jason918
reviewed
Dec 25, 2021
| @@ -105,7 +105,9 @@ public void add(T event, long ts, Record<?> record) { | |||
| public void add(Event<T> windowEvent) { | |||
| // watermark events are not added to the queue. | |||
| if (windowEvent.isWatermark()) { | |||
| log.debug(String.format("Got watermark event with ts %d", windowEvent.getTimestamp())); | |||
| if (log.isDebugEnabled()) { | |||
| log.debug(String.format("Got watermark event with ts %d", windowEvent.getTimestamp())); | |||
There was a problem hiding this comment.
No need to use String.format, just
log.debug("Got watermark event with ts {}", windowEvent.getTimestamp());
There was a problem hiding this comment.
yes , I will delete
| log.debug(String.format("invoking windowLifecycleListener onActivation, [%d] events in " | ||
| + "window.", events.size())); | ||
| if (log.isDebugEnabled()) { | ||
| log.debug(String.format("invoking windowLifecycleListener onActivation, [%d] events in " |
| @@ -216,7 +220,9 @@ private void track(Event<T> windowEvent) { | |||
| lock.unlock(); | |||
| } | |||
| eventsSinceLastExpiry.set(0); | |||
| log.debug(String.format("[%d] events expired from window.", eventsToExpire.size())); | |||
| if (log.isDebugEnabled()) { | |||
| log.debug(String.format("[%d] events expired from window.", eventsToExpire.size())); | |||
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
Jason918
approved these changes
Dec 26, 2021
Anonymitaet
added
doc-not-needed
codelipenghui
approved these changes
Dec 27, 2021
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #13497
Motivation
Optimize the debug log that affects performance, and unify the style
Modifications
add isDebugEnabled method
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc