[security] Allow Client Builder set Dnslookup params #13503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
|
@codelipenghui @lhotari @michaeljmarshall @merlimat @315157973 @hangc0276 PTAL, thanks |
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/test/java/org/apache/pulsar/client/impl/ClientBuilderImplTest.java
Outdated
Show resolved
Hide resolved
…ntBuilderImpl.java Co-authored-by: lipenghui <penghui@apache.org>
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Dec 30, 2021
codelipenghui
requested review from
Technoboy-,
315157973,
BewareMyPower,
gaoran10,
hangc0276 and
merlimat
Technoboy-
reviewed
Dec 31, 2021
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
Technoboy-
approved these changes
Dec 31, 2021
michaeljmarshall
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
related to #13390
Modifications
Verify
testClientBuilderWithIllegalPortcheck for illegal paramDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
docIMO, this change to code will generated doc automatically.