Use PulsarByteBufAllocator to allocate buffer for chunks #13536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
type/enhancement
BewareMyPower
requested review from
merlimat,
rdhabalia,
hangc0276,
eolivelli,
315157973 and
codelipenghui
codelipenghui
approved these changes
Dec 28, 2021
eolivelli
approved these changes
Dec 28, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 30, 2021
…side (#13536) ### Motivation Currently Pulsar consumer allocates memory from direct memory via `Unpooled.directBuffer` directly, which doesn't make use of the widely used allocator in Pulsar. ### Modifications Use `PulsarByteBufAllocator` as the memory allocator for chunks buffer. (cherry picked from commit a5d3473) (cherry picked from commit ddd1f5eb3dfb98b462a42121027cd5b51ed6218b)
codelipenghui
pushed a commit
that referenced
this pull request
Dec 30, 2021
…side (#13536) ### Motivation Currently Pulsar consumer allocates memory from direct memory via `Unpooled.directBuffer` directly, which doesn't make use of the widely used allocator in Pulsar. ### Modifications Use `PulsarByteBufAllocator` as the memory allocator for chunks buffer. (cherry picked from commit a5d3473)
wuzhanpeng
pushed a commit
to wuzhanpeng/pulsar
that referenced
this pull request
Jan 5, 2022
…side (apache#13536) ### Motivation Currently Pulsar consumer allocates memory from direct memory via `Unpooled.directBuffer` directly, which doesn't make use of the widely used allocator in Pulsar. ### Modifications Use `PulsarByteBufAllocator` as the memory allocator for chunks buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently Pulsar consumer allocates memory from direct memory via
Unpooled.directBufferdirectly, which doesn't make use of the widely used allocator in Pulsar.Modifications
Use
PulsarByteBufAllocatoras the memory allocator for chunks buffer.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.