[Issue 13688][client] Fix send chunking message failed when encryption enabled #13689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
|
@gaoran10 @MarvinCai @codelipenghui The root cause is similar to the fix with schemaVersion in #12720. PTAL |
codelipenghui
approved these changes
Jan 12, 2022
codelipenghui
added
release/2.9.2
type/bug
codelipenghui
requested review from
315157973,
BewareMyPower,
gaoran10,
hangc0276 and
merlimat
|
@RobertIndie Please also help review this PR. |
BewareMyPower
approved these changes
Jan 12, 2022
RobertIndie
approved these changes
Jan 13, 2022
gaoran10
approved these changes
Jan 17, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Jan 18, 2022
# Motivation Fix issue #13688. Send chunking message failed with `org.apache.pulsar.client.api.PulsarClientException$TimeoutException` when encryption is enabled. ### Modifications The root cause is that all chunked messages share the same msgMetadata object. The `EncryptionKeys` will be repeated added into message metadata. And proto buffer objects do not support serialization with bytes value type. (cherry picked from commit c1ff87c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13688
Motivation
See #13688
Modifications
The root cause is that all chunked messages shares the same msgMetadata object.
The EncryptionKeys will be repeated added into message metadata.
And proto buffer objects does not support serialization with bytes value type.
Fix by clearing EncryptionKeys before adding.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docBug fix.