Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP-122: change loadbalance shedder to ThresholdShedder and add test #13733

Conversation

hangc0276
Copy link
Contributor

Fix #13340

Modification

  1. Change the default loadbalance default shedder strategy from OverloadShedder to ThresholdShedder
  2. Add test for ThresholdShedder

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Jan 13, 2022
@hangc0276 hangc0276 added this to the 2.10.0 milestone Jan 13, 2022
@hangc0276 hangc0276 changed the title change loadbalance shedder to ThresholdShedder and add test PIP-122: change loadbalance shedder to ThresholdShedder and add test Jan 17, 2022
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding thorough tests @hangc0276!

@hangc0276 hangc0276 force-pushed the chenhang/change_default_loadbalance_shedder_to_thresholdShedder branch from 2100ea8 to d71306f Compare January 27, 2022 09:10
@codelipenghui codelipenghui merged commit f941cbe into apache:master Jan 28, 2022
@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-complete Your PR changes impact docs and the related docs have been already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
5 participants