[broker] Fix producerFuture.completeExceptionally not called before sendErrorResponse #14025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `commandSender.sendErrorResponse` in `ServerCnx.handleProducer`
Jason918
requested review from
merlimat,
hangc0276,
315157973,
codelipenghui,
shoothzj and
michaeljmarshall
HQebupt
approved these changes
Jan 29, 2022
michaeljmarshall
approved these changes
Jan 29, 2022
There was a problem hiding this comment.
LGTM. Thanks for finding these references @Jason918! I looked at this the other day, but clearly I missed these.
codelipenghui
approved these changes
Jan 29, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
… `commandSender.sendErrorResponse` in `ServerCnx.handleProducer` (apache#14025) ### Motivation `producerFuture.completeExceptionally` is not called before `sendErrorResponse` when encryption check or schema check failed in `ServerCnx.handleProduce`. ### Modifications Add `producerFuture.completeExceptionally` before `sendErrorResponse`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
producerFuture.completeExceptionallyis not called beforesendErrorResponsewhen encryption check or schema check failed inServerCnx.handleProduce.Modifications
Add
producerFuture.completeExceptionallybeforesendErrorResponseVerifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docbug fix.