[Broker] Adjust topic exists check logic in http lookup process #14199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
requested review from
aloyszhang,
codelipenghui,
congbobo184,
eolivelli,
hangc0276 and
Technoboy-
Jason918
approved these changes
Feb 10, 2022
codelipenghui
approved these changes
Feb 10, 2022
|
The related change introduced by #13055 and only for the master branch, so don't need to cherry-pick to other branches. |
codelipenghui
added
release/blocker
RobertIndie
approved these changes
Feb 10, 2022
Seems a good idea. @codelipenghui @gaoran10 |
Technoboy-
approved these changes
Feb 10, 2022
|
@Jason918 @Technoboy- Thanks, I improve the logic, please check the last commit. |
Technoboy-
approved these changes
Feb 10, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…he#14199) ### Motivation Currently, it's hard to check the non-persistent-non-partitioned topic exists or not, because it only exists in the broker cache, it doesn't have metadata. If there is a non-persistent and non-partitioned topic exists in broker0 and the configuration `AllowAutoTopicCreation` is false, we perform an HTTP lookup request to broker1, it will return a TopicNotFound exception. ### Modifications If the topic is non-persistent and non-partitioned, we'll return the true flag to ensure the http lookup can return a result. ### Verifying this change Add a test to verify the HTTP lookup request to each broker could return a right lookup result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, it's hard to check the non-persistent-non-partitioned topic exists or not, because it only exists in the broker cache, it doesn't have metadata.
If there is a non-persistent and non-partitioned topic exists in broker0 and the configuration
AllowAutoTopicCreationis false, we perform an HTTP lookup request to broker1, it will return a TopicNotFound exception.Modifications
If the topic is non-persistent and non-partitioned, we'll return the true flag to ensure the http lookup can return a result.
Verifying this change
Add a test to verify the HTTP lookup request to each broker could return a right lookup result.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)