Fix delete namespace issue. #14215
Merged
Fix delete namespace issue. #14215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoothzj
previously approved these changes
Feb 10, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
|
@shibd Could you please help review this PR? |
shibd
reviewed
Feb 11, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
Technoboy-
commented
Feb 11, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
eolivelli
requested changes
Feb 12, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
eolivelli
reviewed
Feb 13, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
RobertIndie
approved these changes
Feb 14, 2022
mattisonchao
approved these changes
Feb 16, 2022
hangc0276
approved these changes
Feb 19, 2022
|
Ping @eolivelli , Please help review this Pr, Thanks. |
codelipenghui
approved these changes
Feb 22, 2022
|
Hi, @eolivelli Could you help review again, thanks . |
codelipenghui
pushed a commit
that referenced
this pull request
Mar 1, 2022
### Motivation When we delete namespace with `force=false`, sometimes there may occur `Cannot delete non empty bundle`. Because delete system topic and delete namespace bundles are put into futures, can't keep their order. We should delete `system topic` first and then delete `namespace bundles`. ### Modifications - Use admin cli to delete system topic. - Delete system topic first and then delete namespace bundles - Make internalClearZkSources async and the code more readable. (cherry picked from commit 145f29a)
|
There's a new flaky test #14516 . @Technoboy- could you please check if it's caused by this PR #14215? |
Ok |
1 task
1 task
codelipenghui
pushed a commit
that referenced
this pull request
Mar 11, 2022
Cherry-pick #14215 ### Motivation When we delete namespace with `force=false`, sometimes there may occur `Cannot delete non empty bundle`. Because delete system topic and delete namespace bundles are put into futures, can't keep their order. We should delete `system topic` first and then delete `namespace bundles`. ### Modifications - Use admin cli to delete system topic. - Delete system topic first and then delete namespace bundles - Make internalClearZkSources async and the code more readable.
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
### Motivation When we delete namespace with `force=false`, sometimes there may occur `Cannot delete non empty bundle`. Because delete system topic and delete namespace bundles are put into futures, can't keep their order. We should delete `system topic` first and then delete `namespace bundles`. ### Modifications - Use admin cli to delete system topic. - Delete system topic first and then delete namespace bundles - Make internalClearZkSources async and the code more readable.
BewareMyPower
removed
cherry-picked/branch-2.8
github-actions
bot
added
doc-label-missing
and removed
doc-not-needed
|
@Technoboy- Please provide a correct documentation label for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we delete namespace with
force=false, sometimes there may occurCannot delete non empty bundle.Because delete system topic and delete namespace bundles are put into futures, can't keep their order.
We should delete
system topicfirst and then deletenamespace bundles.Modifications
Documentation
no-need-doc