-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transaction]Add auth for PerformanceTransaction #14271
Merged
Merged
+261
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation & Modification Add auth for PerformanceTransaction.
github-actions
bot
added
the
doc-required
Your PR changes impact docs and you will update later.
label
Feb 14, 2022
Hi @momo-jun can you follow up on the doc? Thanks |
eolivelli
requested changes
Feb 15, 2022
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceTransaction.java
Outdated
Show resolved
Hide resolved
Sure. Already on it. |
eolivelli
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
codelipenghui
approved these changes
Feb 15, 2022
congbobo184
approved these changes
Feb 16, 2022
Sure. I'm on it. |
1 task
Anonymitaet
added
doc-complete
Your PR changes impact docs and the related docs have been already added.
and removed
doc-required
Your PR changes impact docs and you will update later.
labels
Feb 16, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
### Motivation & Modifications Add auth for PerformanceTransaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Add auth for PerformanceTransaction
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required
Three newly added parameters need to be updated on docs.
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)