Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transaction]Add auth for PerformanceTransaction #14271

Merged
merged 5 commits into from
Feb 16, 2022
Merged

[Transaction]Add auth for PerformanceTransaction #14271

merged 5 commits into from
Feb 16, 2022

Conversation

liangyepianzhou
Copy link
Contributor

Motivation & Modifications

Add auth for PerformanceTransaction

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required
    Three newly added parameters need to be updated on docs.

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

### Motivation & Modification
Add auth for PerformanceTransaction.
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Feb 14, 2022
@Anonymitaet
Copy link
Member

Hi @momo-jun can you follow up on the doc? Thanks

@momo-jun
Copy link
Contributor

Hi @momo-jun can you follow up on the doc? Thanks

Sure. Already on it.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codelipenghui codelipenghui added this to the 2.11.0 milestone Feb 15, 2022
@congbobo184 congbobo184 merged commit 561f8cf into apache:master Feb 16, 2022
@momo-jun
Copy link
Contributor

Hi @momo-jun can you follow up on the doc? Thanks

Sure. I'm on it.

@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Feb 16, 2022
@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.10.0 Feb 17, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
### Motivation & Modifications
Add auth for PerformanceTransaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-complete Your PR changes impact docs and the related docs have been already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants