[Websocket] Fix ClassCastException when user create MultiTopicReader.
#14316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
changed the title
CastException when user create MultiTopicReader by websocket.ClassCastException when user create MultiTopicReader by WebSocket.
mattisonchao
changed the title
ClassCastException when user create MultiTopicReader by WebSocket.ClassCastException when user create MultiTopicReader.
codelipenghui
approved these changes
Feb 16, 2022
|
Maybe we need to cherry-pick this PR to |
Demogorgon314
approved these changes
Feb 16, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
michaeljmarshall
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 5, 2022
…eader``. (apache#14316) (cherry picked from commit 7a7cf54)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 9, 2022
…eader``. (apache#14316) (cherry picked from commit 7a7cf54) (cherry picked from commit 91b9f42)
michaeljmarshall
added a commit
that referenced
this pull request
May 11, 2022
### Motivation This fixes an issue similar to the one solved in #14316. When the `reader` is a `MultiTopicReader`, the `getConsumer()` method currently throws a `ClassCastException`. ### Modifications * Update `MultiTopicReader#getConsumer` so that it safely casts the `reader`. * Update the `ReaderHandler` constructor to use the `getConsumer` method. ### Verifying this change I expanded existing tests to cover the scenario that would have previously failed. ### Does this pull request potentially affect one of the following parts: No, this is not a breaking change.
michaeljmarshall
added a commit
that referenced
this pull request
May 11, 2022
### Motivation This fixes an issue similar to the one solved in #14316. When the `reader` is a `MultiTopicReader`, the `getConsumer()` method currently throws a `ClassCastException`. ### Modifications * Update `MultiTopicReader#getConsumer` so that it safely casts the `reader`. * Update the `ReaderHandler` constructor to use the `getConsumer` method. ### Verifying this change I expanded existing tests to cover the scenario that would have previously failed. ### Does this pull request potentially affect one of the following parts: No, this is not a breaking change. (cherry picked from commit dd6d372)
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
May 11, 2022
…he#15534) ### Motivation This fixes an issue similar to the one solved in apache#14316. When the `reader` is a `MultiTopicReader`, the `getConsumer()` method currently throws a `ClassCastException`. ### Modifications * Update `MultiTopicReader#getConsumer` so that it safely casts the `reader`. * Update the `ReaderHandler` constructor to use the `getConsumer` method. ### Verifying this change I expanded existing tests to cover the scenario that would have previously failed. ### Does this pull request potentially affect one of the following parts: No, this is not a breaking change. (cherry picked from commit dd6d372)
michaeljmarshall
added a commit
that referenced
this pull request
May 11, 2022
### Motivation This fixes an issue similar to the one solved in #14316. When the `reader` is a `MultiTopicReader`, the `getConsumer()` method currently throws a `ClassCastException`. ### Modifications * Update `MultiTopicReader#getConsumer` so that it safely casts the `reader`. * Update the `ReaderHandler` constructor to use the `getConsumer` method. ### Verifying this change I expanded existing tests to cover the scenario that would have previously failed. ### Does this pull request potentially affect one of the following parts: No, this is not a breaking change. (cherry picked from commit dd6d372)
michaeljmarshall
added a commit
to datastax/pulsar
that referenced
this pull request
May 11, 2022
…he#15534) ### Motivation This fixes an issue similar to the one solved in apache#14316. When the `reader` is a `MultiTopicReader`, the `getConsumer()` method currently throws a `ClassCastException`. ### Modifications * Update `MultiTopicReader#getConsumer` so that it safely casts the `reader`. * Update the `ReaderHandler` constructor to use the `getConsumer` method. ### Verifying this change I expanded existing tests to cover the scenario that would have previously failed. ### Does this pull request potentially affect one of the following parts: No, this is not a breaking change. (cherry picked from commit dd6d372)
michaeljmarshall
added a commit
to datastax/pulsar
that referenced
this pull request
May 11, 2022
…he#15534) ### Motivation This fixes an issue similar to the one solved in apache#14316. When the `reader` is a `MultiTopicReader`, the `getConsumer()` method currently throws a `ClassCastException`. ### Modifications * Update `MultiTopicReader#getConsumer` so that it safely casts the `reader`. * Update the `ReaderHandler` constructor to use the `getConsumer` method. ### Verifying this change I expanded existing tests to cover the scenario that would have previously failed. ### Does this pull request potentially affect one of the following parts: No, this is not a breaking change. (cherry picked from commit dd6d372)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Users who use the
WebSocketAPI to create a new reader with the partitioned topic will getClassCastException.Modifications
Verifying this change
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
no-need-doc