[Branch-2.9] Fix Broker HealthCheck Endpoint Exposes Race Conditions. #14658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
requested review from
eolivelli,
Jason918,
codelipenghui,
congbobo184 and
Technoboy-
* Make ``BrokerBase#healthCheck`` to pure async. * fixes checkstyle (cherry picked from commit 488fb78)
…che#14367) (cherry picked from commit 4f1e39b)
gaoran10
force-pushed
the
gaoran/cherry-pick-14367
branch
from
cce8be7
to
0fd3a67
Compare
codelipenghui
approved these changes
Mar 11, 2022
* fix healthcheck v2 * fix failed testHealthCheckupV2 because of error web port Co-authored-by: gavingaozhangmin <gavingaozhangmin@didiglobal.com> (cherry picked from commit b38d850)
gaoran10
force-pushed
the
gaoran/cherry-pick-14367
branch
from
a9c4698
to
4d42d6a
Compare
This was referenced Mar 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #14367
Because the PR #14367 is based on PR #14091, so I want to cherry-pick these two PRs to branch-2.9, the PR #13525 is also needed.
Fix Issue: #14362
Motivation
According to relative PR #7724, we will force delete all subscriptions when calling
healthCheckREST API. but it has a race condition when two threads call this API.Please consider this case:
So, in this case, the reader of thread A is deleted and then an NPE or other exception occurs.
Modifications
Completable#handleto fix problem 1, the reader needs to be closed regardless of whether there is an exception.