Support custom advertised address in pulsar standalone #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
|
should we include it in 1.16 release.? we can merge it and then can do the release today. |
|
@rdhabalia Ok, this is a small change. I'll merge now |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
lhotari
referenced
this pull request
in lhotari/pulsar
Jun 27, 2023
michaeljmarshall
pushed a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Apr 4, 2024
…rmat (apache#187) (cherry picked from commit 7db320b) Conflicts: pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support configuring a custom broker advertised address on standalone broker.
Currently broker advertise itself on
localhostinterface, which can make the standalone Pulsar service unreachable from other machines or containers in the same machine.Modifications
Added new CLI parameter and default to hostname instead of
localhost