Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Branch-2.10] [imporve] [bookie] Upgrade BookKeeper dependency to 4.14.8 for branch 2.10 #21148

Conversation

hangc0276
Copy link
Contributor

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

BookKeeper 4.14.8 has been released: https://github.com/apache/bookkeeper/pull/4053/files

It contains many critical bug fixes and improvements. We need to upgrade the BookKeeper dependency for Pulsar.

Modifications

  • Upgrade BookKeeper dependency from 4.14.7 to 4.14.8
  • Upgrade RocksDB dependency from 6.16.4 to 6.29.4.1

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@hangc0276 hangc0276 self-assigned this Sep 8, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 8, 2023
@hangc0276 hangc0276 added ready-to-test dependencies Pull requests that update a dependency file release/2.10.6 labels Sep 8, 2023
@hangc0276 hangc0276 changed the title [imporve] [bookie] Upgrade BookKeeper dependency to 4.14.8 for branch 2.10 [Branch-2.10] [imporve] [bookie] Upgrade BookKeeper dependency to 4.14.8 for branch 2.10 Sep 8, 2023
@mattisonchao
Copy link
Member

mattisonchao commented Sep 8, 2023

Hi @hangc0276
I saw an error in the CI.

 Could not find artifact org.apache.bookkeeper:bookkeeper-server:jar:tests:4.14.8 in central 

@hangc0276
Copy link
Contributor Author

Hi @hangc0276 I saw an error in the CI.

 Could not find artifact org.apache.bookkeeper:bookkeeper-server:jar:tests:4.14.8 in central 

@mattisonchao I published the artifact to Maven, but it takes some time to be available. I will rerun the tests a few hours later.

@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Technoboy- Technoboy- closed this Sep 18, 2023
@Technoboy- Technoboy- reopened this Sep 18, 2023
@Technoboy- Technoboy- merged commit 5aea813 into apache:branch-2.10 Sep 18, 2023
50 of 58 checks passed
@lhotari lhotari mentioned this pull request Feb 14, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.10 dependencies Pull requests that update a dependency file doc-not-needed Your PR changes do not impact docs ready-to-test release/2.10.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants