[fix][test] Fix flaky CompactionTest.testDispatcherMaxReadSizeBytes #21329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
approved these changes
Oct 9, 2023
lhotari
added
cherry-picked/branch-3.1
and removed
release/3.0.2
release/2.11.3
release/2.10.6
labels
vinayakmalik95
pushed a commit
to tmdc-io/pulsar
that referenced
this pull request
Oct 12, 2023
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 6, 2023
…pache#21329) (cherry picked from commit c883f50)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 8, 2023
…pache#21329) (cherry picked from commit c883f50)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21284
Motivation
CompactionTest.testDispatcherMaxReadSizeBytes is extremely flaky and blocks CI very often.
Modifications
The test had a race condition in the way how the spy was injected into the PersistentTopic instance.
This problem has been fixed now.
Documentation
docdoc-requireddoc-not-neededdoc-complete