[fix][test] Fix a resource leak in ClusterMigrationTest #21366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-fix-clustermigrationtest-resource-leak
branch
from
119752c
to
73d6dae
Compare
@Demogorgon314 I'm investigating. It seems to fail consistently after making the change of cleaning up resources properly. |
lhotari
force-pushed
the
lh-fix-clustermigrationtest-resource-leak
branch
from
73d6dae
to
00ad7de
Compare
|
@Demogorgon314 PTAL, problem should be fixed now. |
|
@vineeth1995 @rdhabalia @vraulji567 I guess we should also consider moving ClusterMigrationTest to it's own test group since the test runtime duration is so long. WDYT? |
lhotari
requested review from
eolivelli,
nicoloboschi,
poorbarcode and
tisonkun
Demogorgon314
approved these changes
Oct 16, 2023
lhotari
added a commit
that referenced
this pull request
Oct 16, 2023
(cherry picked from commit 39235ed) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ClusterMigrationTest.java
lhotari
added a commit
that referenced
this pull request
Oct 16, 2023
(cherry picked from commit 39235ed)
vraulji567
pushed a commit
to vraulji567/pulsar
that referenced
this pull request
Oct 16, 2023
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
(cherry picked from commit 39235ed) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ClusterMigrationTest.java
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
(cherry picked from commit 39235ed) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ClusterMigrationTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Running ClusterMigrationTest could fail with OOME.
When investigating the problem, it showed up that ClusterMigrationTest's TestBroker inner class doesn't clean up resources properly. The admin clients weren't closed.
Modifications
super.internalCleanup()in thecleanupmethod.Documentation
docdoc-requireddoc-not-neededdoc-complete