-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][io] Make connectors load sensitive fields from secrets #21675
[improve][io] Make connectors load sensitive fields from secrets #21675
Conversation
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. left some small comments.
pulsar-io/common/src/main/java/org/apache/pulsar/io/common/IOConfigUtils.java
Show resolved
Hide resolved
pulsar-io/influxdb/src/test/java/org/apache/pulsar/io/influxdb/v1/InfluxDBSinkConfigTest.java
Show resolved
Hide resolved
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java
Show resolved
Hide resolved
pulsar-io/kafka/src/test/java/org/apache/pulsar/io/kafka/sink/KafkaAbstractSinkTest.java
Show resolved
Hide resolved
pulsar-io/mongo/src/test/java/org/apache/pulsar/io/mongodb/MongoSinkConfigTest.java
Show resolved
Hide resolved
pulsar-io/mongo/src/test/java/org/apache/pulsar/io/mongodb/MongoSourceConfigTest.java
Show resolved
Hide resolved
pulsar-io/rabbitmq/src/test/java/org/apache/pulsar/io/rabbitmq/sink/RabbitMQSinkConfigTest.java
Show resolved
Hide resolved
pulsar-io/redis/src/test/java/org/apache/pulsar/io/redis/sink/RedisSinkConfigTest.java
Show resolved
Hide resolved
/pulsarbot rerun-failure-checks |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #21675 +/- ##
=============================================
+ Coverage 36.69% 73.42% +36.72%
- Complexity 12236 32775 +20539
=============================================
Files 1716 1893 +177
Lines 131130 140741 +9611
Branches 14323 15504 +1181
=============================================
+ Hits 48116 103335 +55219
+ Misses 76625 29308 -47317
- Partials 6389 8098 +1709
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…che#21675) (cherry picked from commit c55df07)
…che#21675) (cherry picked from commit c55df07)
I think that this is a very useful improvement, but does this introduce a breaking change for existing users of the connectors? |
Fixes #21674
Main Issue: #xyz
PIP: #xyz
Motivation
Some connectors are using config to pass sensitive fields , like
token
,password
, which is not secureModifications
use the
IOConfileUtils.loadWithSecrets
to load config for connectorsVerifying this change
Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: jiangpengcheng#18