-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip][fix][fn] Add function name and id to producer name to avoid conflict #21912
base: master
Are you sure you want to change the base?
[wip][fix][fn] Add function name and id to producer name to avoid conflict #21912
Conversation
Thanks for your fix. I have a question. After adding the instance name to producerName, can the effectively_once be guaranteed? For example, there was no ack for the message before the failure, but the message was resent after switching to another instance. I think deduplication is invalid at this time because of different producerNames. @jiangpengcheng |
@graysonzeng hm, you are right, let's consider an another way to fix the issue |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #21912 +/- ##
============================================
- Coverage 73.60% 72.39% -1.21%
+ Complexity 32359 32030 -329
============================================
Files 1859 1861 +2
Lines 138373 143467 +5094
Branches 15160 16278 +1118
============================================
+ Hits 101853 103870 +2017
- Misses 28640 31483 +2843
- Partials 7880 8114 +234
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #21911
Main Issue: #xyz
PIP: #xyz
Motivation
there will be producer name conflicts error when function enable effectively_once and subscribed to a partitioned input topic
Modifications
Add functionId and instanceId to the suffix of the producer name to avoid conflicts
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: jiangpengcheng#21