[fix][test] Make base test class method protected so that it passes ReportUnannotatedMethods validation #21976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfused as a test method - PulsarSQL / Trino tests in branch-3.1 fail with this error log: FATAL: io.trino.testng.services.ReportUnannotatedMethods: Test class org.apache.pulsar.sql.presto.TestPulsarAuth has methods which are public but not explicitly annotated. Are they missing @test? public void org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest.reconnectAllConnections() throws java.lang.Exception JVM will be terminated
4 tasks
|
/pulsarbot rerun-failure-checks |
heesung-sn
approved these changes
Jan 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21976 +/- ##
============================================
- Coverage 73.61% 73.59% -0.02%
- Complexity 32433 32450 +17
============================================
Files 1861 1861
Lines 138738 138738
Branches 15200 15200
============================================
- Hits 102130 102109 -21
- Misses 28704 28734 +30
+ Partials 7904 7895 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…eportUnannotatedMethods validation (apache#21976) (cherry picked from commit 67354b1) (cherry picked from commit c315c7b)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…eportUnannotatedMethods validation (apache#21976) (cherry picked from commit 67354b1) (cherry picked from commit c315c7b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
reconnectAllConnectionsmethodprotectedand the static methodprivate.Documentation
docdoc-requireddoc-not-neededdoc-complete