Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fix test testTransactionBufferMetrics #22117

Merged

Conversation

liangyepianzhou
Copy link
Contributor

Motivation

The metric in the testTransactionBufferMetrics will be impact by the other tests, so we should restart before running this test.

java.lang.AssertionError:
Expected :1.0
Actual   :3.0
<Click to see difference>


	at org.testng.Assert.fail(Assert.java:110)
	at org.testng.Assert.failNotEquals(Assert.java:1577)
	at org.testng.Assert.assertEquals(Assert.java:727)
	at org.testng.Assert.assertEquals(Assert.java:774)
	at org.apache.pulsar.broker.transaction.buffer.TransactionBufferClientTest.testTransactionBufferMetrics(TransactionBufferClientTest.java:251)

Modifications

Restart before running this test.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 26, 2024
@liangyepianzhou liangyepianzhou self-assigned this Feb 26, 2024
@liangyepianzhou liangyepianzhou added this to the 3.3.0 milestone Feb 26, 2024
@Technoboy- Technoboy- changed the title [fix][test] fix test testTransactionBufferMetrics [fix][test] Fix test testTransactionBufferMetrics Feb 26, 2024
@Technoboy- Technoboy- closed this Feb 26, 2024
@Technoboy- Technoboy- reopened this Feb 26, 2024
@Technoboy- Technoboy- merged commit 0fc9f44 into apache:master Feb 26, 2024
73 of 77 checks passed
lhotari pushed a commit that referenced this pull request Feb 27, 2024
lhotari pushed a commit that referenced this pull request Feb 27, 2024
lhotari pushed a commit that referenced this pull request Feb 27, 2024
lhotari pushed a commit that referenced this pull request Feb 27, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 1, 2024
(cherry picked from commit 0fc9f44)
(cherry picked from commit b10f9c8)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 6, 2024
(cherry picked from commit 0fc9f44)
(cherry picked from commit b10f9c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants