-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] Fix test testTransactionBufferMetrics #22117
Merged
Technoboy-
merged 1 commit into
apache:master
from
liangyepianzhou:flaky/testTransactionBufferMetrics
Feb 26, 2024
Merged
[fix][test] Fix test testTransactionBufferMetrics #22117
Technoboy-
merged 1 commit into
apache:master
from
liangyepianzhou:flaky/testTransactionBufferMetrics
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
changed the title
[fix][test] fix test testTransactionBufferMetrics
[fix][test] Fix test testTransactionBufferMetrics
Feb 26, 2024
Technoboy-
approved these changes
Feb 26, 2024
lhotari
pushed a commit
that referenced
this pull request
Feb 27, 2024
(cherry picked from commit 0fc9f44)
lhotari
pushed a commit
that referenced
this pull request
Feb 27, 2024
(cherry picked from commit 0fc9f44)
lhotari
pushed a commit
that referenced
this pull request
Feb 27, 2024
(cherry picked from commit 0fc9f44)
lhotari
pushed a commit
that referenced
this pull request
Feb 27, 2024
(cherry picked from commit 0fc9f44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The metric in the
testTransactionBufferMetrics
will be impact by the other tests, so we should restart before running this test.Modifications
Restart before running this test.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: