[fix][client]Fixed getting an incorrect maxMessageSize value when accessing multiple clusters in the same process
#22306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iple clusters in the same process.
|
@chenhongSZ Please add the following content to your PR description and select a checkbox: |
github-actions
bot
added
doc-not-needed
lhotari
added
ready-to-test
type/bug
|
Please fix checkstyle error src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java:[96,8] (imports) UnusedImports: Unused import: org.apache.pulsar.client.impl.ClientCnx. |
fixed |
aloyszhang
approved these changes
Mar 20, 2024
poorbarcode
approved these changes
Mar 20, 2024
|
It might be necessary to fix this test: |
oh, I'll fix it later |
|
/pulsarbot run-failure-checks |
BewareMyPower
approved these changes
Mar 20, 2024
2 tasks
Technoboy-
approved these changes
Mar 20, 2024
hanmz
approved these changes
Mar 20, 2024
dao-jun
approved these changes
Mar 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22306 +/- ##
============================================
+ Coverage 73.57% 73.81% +0.23%
- Complexity 32624 32841 +217
============================================
Files 1877 1887 +10
Lines 139502 139479 -23
Branches 15299 15292 -7
============================================
+ Hits 102638 102955 +317
+ Misses 28908 28600 -308
+ Partials 7956 7924 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/pulsarbot run-failure-checks |
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…ccessing multiple clusters in the same process (apache#22306) Co-authored-by: atomchchen <atomchchen@tencent.com> (cherry picked from commit 71598c1) (cherry picked from commit bff6ea2)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…ccessing multiple clusters in the same process (apache#22306) Co-authored-by: atomchchen <atomchchen@tencent.com> (cherry picked from commit 71598c1) (cherry picked from commit bff6ea2)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…ccessing multiple clusters in the same process (apache#22306) Co-authored-by: atomchchen <atomchchen@tencent.com> (cherry picked from commit 71598c1) (cherry picked from commit bff6ea2)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…ccessing multiple clusters in the same process (apache#22306) Co-authored-by: atomchchen <atomchchen@tencent.com> (cherry picked from commit 71598c1) (cherry picked from commit bff6ea2)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…ccessing multiple clusters in the same process (apache#22306) Co-authored-by: atomchchen <atomchchen@tencent.com> (cherry picked from commit 71598c1) (cherry picked from commit bff6ea2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are using two PulsarClients within the same process to connect to cluster A (maxMessageSize=5M) and cluster B (maxMessageSize=16M), and sometimes the following error occurs.
Got corrupted payload message size 5251327 at org.apache.pulsar.common.api.proto.MessageIdData@5e940463I think the root cause is that the client's
org.apache.pulsar.client.impl.ClientCnx#maxMessageSizevariable is static, which does not support different configurations of two clusters at the same time.Modifications
org.apache.pulsar.client.impl.ClientCnx#maxMessageSizevariable to be non-static, share this variable only within the same connection.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: