[improve][admin] Fix the createMissingPartitions doesn't response correctly
#22311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22311 +/- ##
============================================
+ Coverage 73.57% 73.70% +0.13%
- Complexity 32624 32798 +174
============================================
Files 1877 1887 +10
Lines 139502 139473 -29
Branches 15299 15293 -6
============================================
+ Hits 102638 102801 +163
+ Misses 28908 28711 -197
- Partials 7956 7961 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
approved these changes
Mar 20, 2024
Technoboy-
changed the title
createMissingPartitions doesn't response correctlycreateMissingPartitions doesn't response correctly
hanmz
approved these changes
Mar 20, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…orrectly (apache#22311) (cherry picked from commit 5cabcac) (cherry picked from commit d4c0543)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…orrectly (apache#22311) (cherry picked from commit 5cabcac) (cherry picked from commit d4c0543)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…orrectly (apache#22311) (cherry picked from commit 5cabcac) (cherry picked from commit d4c0543)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…orrectly (apache#22311) (cherry picked from commit 5cabcac) (cherry picked from commit d4c0543)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…orrectly (apache#22311) (cherry picked from commit 5cabcac) (cherry picked from commit d4c0543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the topic metadata doesn't exist, it will create a new PartitionedTopicMetadata with 0 partition. If user use the cli to create missing partitions, it will response
OK, which may confuse user.Modifications
When the metadata partition is 0, throw the NotFound exception to tell the user the topic not existed.
Documentation
docdoc-requireddoc-not-neededdoc-complete