Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ml] Remove duplicated field initialization of ML #22676

Merged
merged 1 commit into from
May 9, 2024

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented May 8, 2024

Motivation

managedLedgerInterceptor of ManagedLedgerImpl initialized twice, remove one
image

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dao-jun dao-jun added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use ready-to-test area/ML labels May 8, 2024
@dao-jun dao-jun added this to the 3.4.0 milestone May 8, 2024
@dao-jun dao-jun self-assigned this May 8, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 8, 2024
@Technoboy- Technoboy- merged commit 88feb87 into apache:master May 9, 2024
54 of 57 checks passed
@dao-jun dao-jun deleted the fix/remove_dup_filed_init branch May 9, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ML doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants