C++ Client - Async call for getConsumerStat #255
Conversation
pulsar-client-cpp/lib/Consumer.cc
Outdated
| if (!impl_) { | ||
| return ResultConsumerNotInitialized; | ||
| } | ||
| return impl_->getConsumerStats(BrokerConsumerStats, partitionIndex); | ||
| Promise<Result, BrokerConsumerStats> promise; | ||
| impl_->getConsumerStatsAsync(WaitForCallbackValue<BrokerConsumerStats>(promise), partitionIndex); |
There was a problem hiding this comment.
Isn't it better to call the local getConsumerStatsAsync() ?
There was a problem hiding this comment.
I can call Consumer-> getConsumerStatsAsync() instead of impl_-> getConsumerStatsAsync
but I saw the code for acknowledge() and unsubscribe() - they both call the async function in the impl_
| , BrokerConsumerStatsCallback callback) { | ||
|
|
||
| if (res == ResultOk) { | ||
| Lock lock(mutex_); |
There was a problem hiding this comment.
Do we need the lock here?
There was a problem hiding this comment.
yes, to protect brokerConsumerStats_ in case getConsumerStats is called using multiple threads using the same consumer objects.
| brokerConsumerStats = brokerConsumerStats_; | ||
| return ResultOk; | ||
| lock.unlock(); | ||
| return callback(ResultOk, brokerConsumerStats_); |
There was a problem hiding this comment.
this callback isn't safe as you just dropped the lock. need to copy brokerConsumerStats_ before unlocking.
There was a problem hiding this comment.
@msb-at-yahoo - handled
jai1
force-pushed
the
AsyncCallForBrokerStats
branch
from
2ee87b3
to
2618954
Compare
…llForBrokerStats
|
Closing the PR - need to think a little more about this - sorry for the unneccessary noise. |
* Fix perf-produce cannot be closed Signed-off-by: xiaolong.ran <rxl@apache.org> * fix comments Signed-off-by: xiaolong.ran <rxl@apache.org> * fix comments Signed-off-by: xiaolong.ran <rxl@apache.org> * fix comments Signed-off-by: xiaolong.ran <rxl@apache.org>
Motivation
C++ Client - Async call for getConsumerStats - as a part of #216
Modifications
Slightly changed the CPP Client flow for getConsumerStats and added support for async call
Result
CPP Client will have the ability to get consumer stats asynchronously