Added pause and resume to Java client Consumer #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Nov 8, 2018
There was a problem hiding this comment.
The change looks good. Just left one comment regarding pause and receive interactions.
Can you also add unit tests for this feature, for both partitioned vs non-partitioned topics. Take a look at https://github.com/apache/pulsar/blob/master/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java#L197 or https://github.com/apache/pulsar/blob/master/pulsar-broker/src/test/java/org/apache/pulsar/client/api/PartitionedProducerConsumerTest.java#L167
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
Outdated
Show resolved
Hide resolved
merlimat
added
the
type/feature
|
I added tests. Tx. |
|
run integration tests |
jai1
reviewed
Nov 9, 2018
...nk/src/test/java/org/apache/flink/streaming/connectors/pulsar/PulsarConsumerSourceTests.java
Outdated
Show resolved
Hide resolved
|
run integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is useful to be able to control message flow from the client but still use MessageListener to be notified when new messages arrive. Currently you have to use Consumer.receive() and receiverQueueSize which requires polling, which is inefficient for thousands of consumers. The C++ client has Consumer.pauseMessageListener() and resumeMessageListener().
Modifications
Added Consumer.pause() and Consumer.resume(). When paused the consumer does not send requests for more messages to the broker. This works when using MessageListener and Consumer.receive() which is why I didn't use the same names as the C++ client.
Result
Applications using the Java API can now do client side message flow control very easily based on their own internal state.