Exclude netty individual jars from binary distribution #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdhabalia @saandrews This should be possibly backported to 1.16 branch |
rdhabalia
pushed a commit
that referenced
this pull request
Mar 23, 2017
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
* Add rerun feature test command to repo Signed-off-by: xiaolong.ran <rxl@apache.org> * rename bot.yaml Signed-off-by: xiaolong.ran <rxl@apache.org> * fix ci error Signed-off-by: xiaolong.ran <rxl@apache.org> * fix ci error Signed-off-by: xiaolong.ran <rxl@apache.org>
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
…vert properly (apache#311) When `KafkaConsumer` send OffsetCommitRequest, the field `retentionTime` is always set to -1, and kafka server convert the retentionTime according to server config. this patch add convert logic the same as kafka server to avoid kop expire the wrong commit offset in `GroupMetadataManager.cleanupGroupMetadata` logic. test in `KafkaRequestHandlerTest.testOffsetCommitRequestRetentionMs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Maven assembly plugin is including individual Netty jars, even though we have a dependency exclusion. These packages are conflicting with the
netty-allpackage that we are already including.Modifications
Setup exclusion in the maven assembly configuration.
Fix #277