Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude netty individual jars from binary distribution #311

Merged
merged 1 commit into from Mar 23, 2017

Conversation

@merlimat
Copy link
Contributor

merlimat commented Mar 23, 2017

Motivation

Maven assembly plugin is including individual Netty jars, even though we have a dependency exclusion. These packages are conflicting with the netty-all package that we are already including.

Modifications

Setup exclusion in the maven assembly configuration.

Fix #277

@merlimat merlimat added the type/bug label Mar 23, 2017
@merlimat merlimat added this to the 1.17 milestone Mar 23, 2017
@merlimat merlimat self-assigned this Mar 23, 2017
@merlimat merlimat requested review from rdhabalia and saandrews Mar 23, 2017
@merlimat

This comment has been minimized.

Copy link
Contributor Author

merlimat commented Mar 23, 2017

@rdhabalia @saandrews This should be possibly backported to 1.16 branch

Copy link
Contributor

rdhabalia left a comment

👍

@rdhabalia rdhabalia merged commit 181172f into apache:master Mar 23, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
cla/licenses User has a valid Yahoo CLA
Details
rdhabalia added a commit that referenced this pull request Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.