Fixed C++ batch acks tracker to evict message from sendList array #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
jerrypeng
approved these changes
Feb 17, 2019
kramasamy
approved these changes
Feb 17, 2019
|
Merged in 2.3.1 at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In c++ consumer, when receiving batched messages, the acknowledgment tracker is incorrectly trying remove the messageId from the last message in batch being acked from the
sendList. In that list, the message ids being inserted are always the ones from the batch, not the individual messages.The result of this is that the sendList keeps growing, using memory and making the linear search to skyrocket in cpu/time.
Note: this is just a quick fix to address the most pressing issue. A better fix will be to implement an equivalent of #1424.