Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 3987][pulsar-broker]Handle config is null when create tenant #4019

Merged

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Apr 10, 2019

Fixes #3987

Motivation

Config will not appear null when create tenant use pulsar-admin create foo3, but use the following command, config is null.

curl -X PUT http://localhost:8080/admin/v2/tenants/foo3

Modifications

Handle config is null when create tenant use curl.

Verifying this change

Test pass

curl -X PUT http://localhost:8080/admin/v2/tenants/foo3
curl -X GET http://localhost:8080/admin/v2/tenants/foo3
{"adminRoles":[],"allowedClusters":[]}

Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@tuteng is it possible to add a test for this?

@merlimat merlimat added this to the 2.4.0 milestone Apr 10, 2019
@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Apr 10, 2019
@sijie sijie modified the milestones: 2.4.0, 2.3.2 Apr 11, 2019
@sijie sijie merged commit 61e9e1b into apache:master Apr 11, 2019
@sijie sijie deleted the fix/handle-config-is-null-when-create-tenant branch April 11, 2019 06:08
merlimat pushed a commit that referenced this pull request May 19, 2019
…4019)

Fixes #3987 

### Motivation

Config will not appear null when create tenant use pulsar-admin create foo3, but use the following command, config is null.
```
curl -X PUT http://localhost:8080/admin/v2/tenants/foo3
```

### Modifications

Handle config is null when create tenant use curl.

### Verifying this change
Test pass
```
curl -X PUT http://localhost:8080/admin/v2/tenants/foo3
curl -X GET http://localhost:8080/admin/v2/tenants/foo3
{"adminRoles":[],"allowedClusters":[]}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants