Allow users to update auth data during function update #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun java8 tests |
merlimat
approved these changes
May 3, 2019
|
rerun java8 tests |
sijie
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, after a function is submitted there is no way to update the auth data associated with the function.
Users may want to be able to update the auth data of a function that is running.
This will especially support use cases involving initially running Pulsar without authentication enabled but then enabling authentication. Functions need to be able to be updated to have auth data for a seamless transition
Modifications
Allow users to update the auth data when updating a function.
Have a flag to control whether to update the auth data of the function or simply keep using the existing auth data
Improve the FunctionAuthProvider interface to support this use case