[pulsar-storm] support reader for pulsar-spout #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
changed the title
|
rerun java8 tests |
|
rerun java8 tests |
|
run java8 tests |
|
rerun java8 tests |
1 similar comment
|
rerun java8 tests |
|
run java8 tests |
jiazhai
approved these changes
May 20, 2019
There was a problem hiding this comment.
+1. lgtm.
It would be great if @jerrypeng could help review it since Jerry knows Storm better.
…rable subscription
|
rerun java8 tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Many time user wants to submit storm task which reads from cms without creating durable subscription. So, add support for reader in pulsar-spout.