-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] fix peek parse message error #4918
Conversation
801e1a5
to
409e63f
Compare
393db26
to
a2b6ec2
Compare
From a functionality point of view looks good to me. Can't really comment on how Pythonic the code is as I only hack Python. |
a2b6ec2
to
fc30648
Compare
take a closer look about the api implementation, found that this is a wrong deserialize implementation, it didn't distinguish the batch mode or not. sorry for that, just hold it. |
fc30648
to
ed664d7
Compare
For now, we can not parse batch messages payload without metadata pb struct except those with size of 1. So in this PR, only parse rightly for normal and 1-batch message, and display the size only of other batch messages. It can be resolved in another PR for those batch messages if need. @sijie what do you think? |
ed664d7
to
ce86537
Compare
ce86537
to
2df9a41
Compare
@yittg sgtm |
@sijie yeah, let's do it, PTAL. by the way, here's some screenshots: |
run cpp tests |
@tuteng can you please help review this? |
lgtm |
Fixes #4917
Motivation
dashboard peek message api raise exception when format response cause treat all message as a JSON string
Modifications