[admin] DeleteBookieRack should remove the rack info from zookeeper #5084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* Currently deleteBookieRackInfo doesn't actually remove rack info from zookeeper. So if a broker restarts, you still can get the *deleted* bookie rack info. *Modification* - Fix the deleteBbookieInfo logic to update rack configuration in zookeeper - Remove a group from the map if the group is empty
|
run java8 tests |
codelipenghui
approved these changes
Aug 31, 2019
|
run java8 tests |
1 similar comment
|
run java8 tests |
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
…5084) *Motivation* Currently deleteBookieRackInfo doesn't actually remove rack info from zookeeper. So if a broker restarts, you still can get the *deleted* bookie rack info. *Modification* - Fix the deleteBbookieInfo logic to update rack configuration in zookeeper - Remove a group from the map if the group is empty (cherry picked from commit 4cd25ee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently deleteBookieRackInfo doesn't actually remove rack info from zookeeper.
So if a broker restarts, you still can get the deleted bookie rack info.
Modification