Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Functions unnecessarily restart during FunctionRuntimeManager init phase #5527

Merged
merged 2 commits into from
Nov 1, 2019
Merged

fix: Functions unnecessarily restart during FunctionRuntimeManager init phase #5527

merged 2 commits into from
Nov 1, 2019

Conversation

jerrypeng
Copy link
Contributor

Motivation

During the init phase of FunctionRuntimeManager, functions may be unnecessarily restarted. This impacts running functions via external schedulers e.g. Kubernetes

Modifications

  • Don't set any of the FunctionRuntimeInfo during init time.
  • Fixed a test to check for check for this

@jerrypeng jerrypeng added type/bug The PR fixed a bug or issue reported a bug area/function labels Oct 31, 2019
@jerrypeng jerrypeng added this to the 2.4.2 milestone Oct 31, 2019
@jerrypeng jerrypeng self-assigned this Oct 31, 2019
merlimat
merlimat reviewed Oct 31, 2019
View reviewed changes
...unctions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java Outdated
}

@VisibleForTesting
FunctionRuntimeInfos functionRuntimeInfos = new FunctionRuntimeInfos();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FunctionRuntimeInfos functionRuntimeInfos = new FunctionRuntimeInfos();
final FunctionRuntimeInfos functionRuntimeInfos = new FunctionRuntimeInfos();

@jerrypeng
Copy link
Contributor Author

rerun cpp tests

@wolfstudy
Copy link
Member

run java8 tests

1 similar comment
@wolfstudy
Copy link
Member

run java8 tests

@wolfstudy wolfstudy merged commit dd58baf into apache:master Nov 1, 2019
wolfstudy pushed a commit that referenced this pull request Nov 20, 2019
@jerrypeng @wolfstudy
fix: Functions unnecessarily restart during FunctionRuntimeManager in…
9671090 
…it phase (#5527)

* fix: Functions unnecessarily restart during FunctionRuntimeManager init phase

(cherry picked from commit dd58baf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@wolfstudy wolfstudy wolfstudy approved these changes

@sijie sijie Awaiting requested review from sijie

@srkukarni srkukarni Awaiting requested review from srkukarni

@aahmed-se aahmed-se Awaiting requested review from aahmed-se

Assignees

@jerrypeng jerrypeng

Labels
area/function type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jerrypeng @wolfstudy @merlimat