Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java-client] Add support for key hash range reading. #5928

Merged
merged 3 commits into from Jan 9, 2020

Conversation

@codelipenghui
Copy link
Contributor

codelipenghui commented Dec 24, 2019

Master Issue: #4077

Motivation

Add support for sticky key hash range reader. Broker will only dispatch messages which hash of the message key contains by the specified key hash range.

Multiple key hash ranges can be specified on a reader by following example:

pulsarClient.newReader()
                    .topic(topic)
                    .startMessageId(MessageId.earliest)
                    .keyHashRange(Range.of(0, 10000), Range.of(20001, 30000))
                    .create();

Verifying this change

New unit tests was added for cover this change

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes )
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
@codelipenghui codelipenghui requested review from rdhabalia, merlimat, massakam, jiazhai and sijie and removed request for rdhabalia, merlimat and massakam Dec 24, 2019
@codelipenghui codelipenghui self-assigned this Dec 24, 2019
@codelipenghui codelipenghui mentioned this pull request Dec 24, 2019
8 of 15 tasks complete
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 24, 2019

run java8 tests
run integration tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 24, 2019

run cpp tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 24, 2019

rerun java8 tests

1 similar comment
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 24, 2019

rerun java8 tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 24, 2019

run java8 tests
run integration tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 24, 2019

run java8 tests

2 similar comments
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 25, 2019

run java8 tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 25, 2019

run java8 tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 26, 2019

rerun java8 tests

2 similar comments
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 26, 2019

rerun java8 tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Dec 26, 2019

rerun java8 tests

@sijie sijie mentioned this pull request Dec 27, 2019
8 of 15 tasks complete
@sijie
sijie approved these changes Jan 6, 2020
Copy link
Member

sijie left a comment

LGTM +1

@codelipenghui well done!

Can you rebase this pull request to master?

@sijie sijie added this to the 2.6.0 milestone Jan 6, 2020
@codelipenghui codelipenghui force-pushed the codelipenghui:key_range_reader branch Jan 6, 2020
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Jan 6, 2020

retest this please

1 similar comment
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Jan 7, 2020

retest this please

@codelipenghui codelipenghui force-pushed the codelipenghui:key_range_reader branch to 8d297ed Jan 8, 2020
@sijie

This comment has been minimized.

Copy link
Member

sijie commented Jan 8, 2020

run java8 tests
run integration tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Jan 9, 2020

run integration tests

@codelipenghui codelipenghui merged commit 5fc4a90 into apache:master Jan 9, 2020
14 of 18 checks passed
14 of 18 checks passed
cpp-tests cpp-tests
Details
process process
Details
unit-test-flaky unit-test-flaky
Details
unit-tests unit-tests
Details
backwards-compatibility
Details
cli
Details
function-state
Details
messaging
Details
schema
Details
sql
Details
standalone
Details
thread
Details
tiered-filesystem
Details
tiered-jcloud
Details
License check
Details
Jenkins: C++ / Python Tests SUCCESS
Details
Jenkins: Integration Tests SUCCESS
Details
Jenkins: Java 8 - Unit Tests SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.