[Issue 5902] Support to get managed ledger info of a partitioned topic #6532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
|
|
||
| import java.util.Map; | ||
|
|
||
| public class PartitionedManagedLedgerInfo extends ManagedLedgerInfo { |
There was a problem hiding this comment.
It's better to move it to the broker module since the mledger does not have any concepts about partition.
|
@codelipenghui Please help to review again, thanks. |
codelipenghui
approved these changes
Mar 16, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Mar 18, 2020
sijie
added
the
doc-required
Anonymitaet
removed
the
doc-required
|
Doc has been added: https://pulsar.apache.org/docs/en/next/pulsar-admin/#info-internal |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
apache#6532) ### Motivation Fixes apache#5902 If there is a partitioned topic with too many partitions, users need to get the `internal-info` one by one. If called `internal-info` on a partitioned topic, it fails as below: ``` $ bin/pulsar-admin topics info-internal persistent://public/default/test2 HTTP 400 Bad Request Reason: HTTP 400 Bad Request ``` ### Modifications Support to get all partitions `internal-info` of a partitioned topic, seems like below: ``` $ bin/pulsar-admin topics info-internal persistent://public/default/test2 { "version": 0, "partitions": { "persistent://public/default/test2-partition-1": { "version": 1, "creationDate": "2020-03-12T21:24:52.777+08:00", "modificationDate": "2020-03-12T21:25:50.85+08:00", "ledgers": [ { "ledgerId": 16 } ], "cursors": { "test2-sub": { "version": 0, "creationDate": "2020-03-12T21:25:51.178+08:00", "modificationDate": "2020-03-12T21:25:51.178+08:00", "cursorsLedgerId": 18, "markDelete": { "ledgerId": 16, "entryId": -1 } } } }, "persistent://public/default/test2-partition-0": { "version": 1, "creationDate": "2020-03-12T21:24:52.777+08:00", "modificationDate": "2020-03-12T21:25:50.952+08:00", "ledgers": [ { "ledgerId": 17 } ], "cursors": { "test2-sub": { "version": 0, "creationDate": "2020-03-12T21:25:51.177+08:00", "modificationDate": "2020-03-12T21:25:51.177+08:00", "cursorsLedgerId": 19, "markDelete": { "ledgerId": 17, "entryId": -1 } } } } } } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #5902
If there is a partitioned topic with too many partitions, users need to get the
internal-infoone by one. If calledinternal-infoon a partitioned topic, it fails as below:Modifications
Support to get all partitions
internal-infoof a partitioned topic, seems like below: