[pulsar-broker] check replicator periodically to avoid issue due to zk missing watch #6674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
requested review from
merlimat,
maskit,
sijie,
jiazhai,
jai1,
codelipenghui,
saandrews and
massakam
sijie
approved these changes
Apr 7, 2020
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
May 7, 2020
…k missing watch (apache#6674) ### Motivation We have a regular issue when user changes replication-cluster list, many times broker misses the zk watch and broker fails to update replicator which causes either data loss or message backlog based on zk-watch missing at source or destination replication broker. ### Modification - Broker expires replication policies at every X seconds - Starts a background task which checks polices (fetches new policies if it's already expired) and starts/stops replicator if needed. ### Result Broker can start/stop replicators based on updated policies even if broker misses zk watch.
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
Jun 12, 2020
…k missing watch (apache#6674) ### Motivation We have a regular issue when user changes replication-cluster list, many times broker misses the zk watch and broker fails to update replicator which causes either data loss or message backlog based on zk-watch missing at source or destination replication broker. ### Modification - Broker expires replication policies at every X seconds - Starts a background task which checks polices (fetches new policies if it's already expired) and starts/stops replicator if needed. ### Result Broker can start/stop replicators based on updated policies even if broker misses zk watch.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…k missing watch (apache#6674) ### Motivation We have a regular issue when user changes replication-cluster list, many times broker misses the zk watch and broker fails to update replicator which causes either data loss or message backlog based on zk-watch missing at source or destination replication broker. ### Modification - Broker expires replication policies at every X seconds - Starts a background task which checks polices (fetches new policies if it's already expired) and starts/stops replicator if needed. ### Result Broker can start/stop replicators based on updated policies even if broker misses zk watch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have a regular issue when user changes replication-cluster list, many times broker misses the zk watch and broker fails to update replicator which causes either data loss or message backlog based on zk-watch missing at source or destination replication broker.
Modification
Result
Broker can start/stop replicators based on updated policies even if broker misses zk watch.