-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more detail information of retry errors #7341
Conversation
--- *Motivation* Currently, when you connecting to a wrong address, the error log does not show the detail information to let you know why it failed. Add the failed reason to know more about the error. Before adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. ``` After adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081 ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please take a look at the check style issue?
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
3 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
5 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
--- *Motivation* Currently, when you connecting to a wrong address, the error log does not show the detail information to let you know why it failed. Add the failed reason to know more about the error. Before adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. ``` After adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081 ``` (cherry picked from commit f4547ec)
--- *Motivation* Currently, when you connecting to a wrong address, the error log does not show the detail information to let you know why it failed. Add the failed reason to know more about the error. Before adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. ``` After adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081 ``` (cherry picked from commit f4547ec)
--- *Motivation* Currently, when you connecting to a wrong address, the error log does not show the detail information to let you know why it failed. Add the failed reason to know more about the error. Before adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. ``` After adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081 ```
Motivation
Currently, when you connecting to a wrong address, the error
log does not show the detail information to let you know why
it failed. Add the failed reason to know more about the error.
Before adding the error log:
After adding the error log: