Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail information of retry errors #7341

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Conversation

zymap
Copy link
Member

@zymap zymap commented Jun 23, 2020


Motivation

Currently, when you connecting to a wrong address, the error
log does not show the detail information to let you know why
it failed. Add the failed reason to know more about the error.

Before adding the error log:

bin/pulsar-admin topics list public/default
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.

After adding the error log:

bin/pulsar-admin topics list public/default
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081

---

*Motivation*

Currently, when you connecting to a wrong address, the error
log does not show the detail information to let you know why
it failed. Add the failed reason to know more about the error.

Before adding the error log:

```
bin/pulsar-admin topics list public/default
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.
```

After adding the error log:

```
bin/pulsar-admin topics list public/default
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081
```
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please take a look at the check style issue?

@zymap
Copy link
Member Author

zymap commented Jun 29, 2020

/pulsarbot run-failure-checks

@zymap
Copy link
Member Author

zymap commented Jun 30, 2020

/pulsarbot run-failure-checks

3 similar comments
@zymap
Copy link
Member Author

zymap commented Jun 30, 2020

/pulsarbot run-failure-checks

@zymap
Copy link
Member Author

zymap commented Jun 30, 2020

/pulsarbot run-failure-checks

@zymap
Copy link
Member Author

zymap commented Jul 1, 2020

/pulsarbot run-failure-checks

@zymap
Copy link
Member Author

zymap commented Jul 1, 2020

/pulsarbot run-failure-checks

5 similar comments
@zymap
Copy link
Member Author

zymap commented Jul 2, 2020

/pulsarbot run-failure-checks

@zymap
Copy link
Member Author

zymap commented Jul 2, 2020

/pulsarbot run-failure-checks

@zymap
Copy link
Member Author

zymap commented Jul 2, 2020

/pulsarbot run-failure-checks

@zymap
Copy link
Member Author

zymap commented Jul 3, 2020

/pulsarbot run-failure-checks

@zymap
Copy link
Member Author

zymap commented Jul 6, 2020

/pulsarbot run-failure-checks

@sijie sijie merged commit f4547ec into apache:master Jul 6, 2020
codelipenghui pushed a commit to streamnative/pulsar-archived that referenced this pull request Jul 14, 2020
---

*Motivation*

Currently, when you connecting to a wrong address, the error
log does not show the detail information to let you know why
it failed. Add the failed reason to know more about the error.

Before adding the error log:

```
bin/pulsar-admin topics list public/default
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.
```

After adding the error log:

```
bin/pulsar-admin topics list public/default
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081
```

(cherry picked from commit f4547ec)
wolfstudy pushed a commit that referenced this pull request Jul 29, 2020
---

*Motivation*

Currently, when you connecting to a wrong address, the error
log does not show the detail information to let you know why
it failed. Add the failed reason to know more about the error.

Before adding the error log:

```
bin/pulsar-admin topics list public/default
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.
```

After adding the error log:

```
bin/pulsar-admin topics list public/default
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081
```

(cherry picked from commit f4547ec)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
---

*Motivation*

Currently, when you connecting to a wrong address, the error
log does not show the detail information to let you know why
it failed. Add the failed reason to know more about the error.

Before adding the error log:

```
bin/pulsar-admin topics list public/default
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.
```

After adding the error log:

```
bin/pulsar-admin topics list public/default
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants