[broker] Consumer is registered on dispatcher even if hash range conflicts on Key_Shared subscription #7444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Key_Shared subscription
merlimat
approved these changes
Jul 3, 2020
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Jul 14, 2020
…Key_Shared subscription (apache#7444) (cherry picked from commit 97ee82e)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…Key_Shared subscription (apache#7444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If hash ranges specified by multiple consumers conflict on a Key_Shared subscription, the consumer that connects later will fail to subscribe. When this happens, the consumer that should have failed to subscribe is added to the topic stats. These "non-existent" consumers will not disappear until the broker server is restarted.
When the hash ranges conflict, an exception is thrown from
HashRangeExclusiveStickyKeyConsumerSelector#addConsumer(). However, at that time, the addition of the consumer toconsumerListandconsumerSetof the dispatcher has already been completed, and it will not be removed.pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
Lines 94 to 96 in 1bdfc0d
Modifications
If an exception is thrown from
HashRangeExclusiveStickyKeyConsumerSelector#addConsumer(), remove the consumer added toconsumerListandconsumerSet.