fix #6834: add pulsar-client-messagecrypto-bc into pulsar-client dependency to avoid method not found #7447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jul 5, 2020
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Jul 14, 2020
…7447) Fixes apache#6834 ### Motivation `MessageCryptoBc` implements the interface of `MessageCrypto`. while `pulsar-client` did a shade to`ByteBuf`, and caused the method parameter changed from `org.apache.pulsar.shade.io.netty.buffer.ByteBuf` to `io.netty.buffer.ByteBuf` and will cause error of: ``` Caused by: java.lang.NoSuchMethodError: 'org.apache.pulsar.shade.io.netty.buffer.ByteBuf org.apache.pulsar.client.api.MessageCrypto.encrypt(java.util.Set, org.apache.pulsar.client.api.CryptoKeyReader, java.util.function.Supplier, org.apache.pulsar.shade.io.netty.buffer.ByteBuf) ``` ### Modifications add pulsar-client-messagecrypto-bc into pulsar-client dependency to avoid method-not-found issue. (cherry picked from commit d83133a)
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
Fixes #6834 ### Motivation `MessageCryptoBc` implements the interface of `MessageCrypto`. while `pulsar-client` did a shade to`ByteBuf`, and caused the method parameter changed from `org.apache.pulsar.shade.io.netty.buffer.ByteBuf` to `io.netty.buffer.ByteBuf` and will cause error of: ``` Caused by: java.lang.NoSuchMethodError: 'org.apache.pulsar.shade.io.netty.buffer.ByteBuf org.apache.pulsar.client.api.MessageCrypto.encrypt(java.util.Set, org.apache.pulsar.client.api.CryptoKeyReader, java.util.function.Supplier, org.apache.pulsar.shade.io.netty.buffer.ByteBuf) ``` ### Modifications add pulsar-client-messagecrypto-bc into pulsar-client dependency to avoid method-not-found issue. (cherry picked from commit d83133a)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…7447) Fixes apache#6834 ### Motivation `MessageCryptoBc` implements the interface of `MessageCrypto`. while `pulsar-client` did a shade to`ByteBuf`, and caused the method parameter changed from `org.apache.pulsar.shade.io.netty.buffer.ByteBuf` to `io.netty.buffer.ByteBuf` and will cause error of: ``` Caused by: java.lang.NoSuchMethodError: 'org.apache.pulsar.shade.io.netty.buffer.ByteBuf org.apache.pulsar.client.api.MessageCrypto.encrypt(java.util.Set, org.apache.pulsar.client.api.CryptoKeyReader, java.util.function.Supplier, org.apache.pulsar.shade.io.netty.buffer.ByteBuf) ``` ### Modifications add pulsar-client-messagecrypto-bc into pulsar-client dependency to avoid method-not-found issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6834
Motivation
MessageCryptoBcimplements the interface ofMessageCrypto. whilepulsar-clientdid a shade toByteBuf, and caused the method parameter changed fromorg.apache.pulsar.shade.io.netty.buffer.ByteBuftoio.netty.buffer.ByteBufand will cause error of:Modifications
add pulsar-client-messagecrypto-bc into pulsar-client dependency to avoid method-not-found issue.